-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve bundled modules from correct location #11493
fix: resolve bundled modules from correct location #11493
Conversation
@merceyz sorry to ping you, but do you have any tips for how to make the script I added as a "test" work? Using just Using |
Codecov Report
@@ Coverage Diff @@
## master #11493 +/- ##
==========================================
- Coverage 68.95% 68.94% -0.02%
==========================================
Files 312 312
Lines 16310 16314 +4
Branches 4722 4726 +4
==========================================
Hits 11247 11247
- Misses 5035 5039 +4
Partials 28 28
Continue to review full report at Codecov.
|
d007a65
to
c94ec5d
Compare
Moved test to #11513 |
@SimenB No worries, responded in #11513 (comment) |
Instead of passing the require function around, wouldn't passing the filepath instead be better?
|
Passing in |
Depends on where it should be resolved relative to, but yeah |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Take 2 at fixing #11452. This time by passing in
require.resolve
from the modules that do therequire
so that it looks like it's e.g.jest-config
doing therequire.resolve
rather thanjest-resolve
, thus satisfying the dependencyTest plan
🤷